Skip to content

CNF-13731: Add HTTP01ChallengeProxy types (PoC) - #2318

Closed
sebrandon1 wants to merge 1 commit into
openshift:masterfrom
sebrandon1:cert_manager_proxy
Closed

CNF-13731: Add HTTP01ChallengeProxy types (PoC)#2318
sebrandon1 wants to merge 1 commit into
openshift:masterfrom
sebrandon1:cert_manager_proxy

Conversation

@sebrandon1

@sebrandon1 sebrandon1 commented May 12, 2025

Copy link
Copy Markdown
Member

Opening this PR a compliment to my enhancement PR here: openshift/enhancements#1773

This is just a proof of concept at the moment so I'll still be working on it.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label May 12, 2025
@openshift-ci-robot

openshift-ci-robot commented May 12, 2025 •
edited by openshift-ci Bot
Loading

Copy link
Copy Markdown

@sebrandon1: This pull request references CNF-13731 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target the "4.20.0" version, but no target version was set.

Details

In response to this:

Opening this PR a compliment to my enhancement PR here: openshift/enhancements#1773

This is just a proof of concept at the moment so I'll still be working on it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci

openshift-ci Bot commented May 12, 2025

Copy link
Copy Markdown
Contributor

Hello @sebrandon1! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

@openshift-ci openshift-ci Bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label May 12, 2025
@openshift-ci
openshift-ci Bot requested review from deads2k and knobunc May 12, 2025 19:38
@openshift-ci

openshift-ci Bot commented May 12, 2025

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: sebrandon1
Once this PR has been reviewed and has the lgtm label, please assign joelspeed for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sebrandon1 sebrandon1 mentioned this pull request May 12, 2025
Closed
@sebrandon1
sebrandon1 force-pushed the cert_manager_proxy branch from a26faf5 to 82240de Compare May 12, 2025 21:03
@openshift-ci

openshift-ci Bot commented May 12, 2025

Copy link
Copy Markdown
Contributor

@sebrandon1: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/verify 82240de link true /test verify
ci/prow/lint 82240de link true /test lint
ci/prow/verify-client-go 82240de link true /test verify-client-go

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 23, 2025
@openshift-merge-robot

openshift-merge-robot commented May 23, 2025

Copy link
Copy Markdown
Contributor

PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@sebrandon1 sebrandon1 closed this Aug 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@deads2k deads2k Awaiting requested review from deads2k
@knobunc knobunc Awaiting requested review from knobunc

Assignees

No one assigned

Labels

jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sebrandon1 @openshift-ci-robot @openshift-merge-robot